Hi Andrew,
On 2014-02-14 07:42:00, you wrote to me:
WvV>> I want to suggest the following changes to the makenl code:
AL> I will most likely incorporate these for 3.4.3. Thanks for the
AL> suggestions.
Your welcome...
WvV>> Because in the 3.4.2 version (or a version inbetween) fixes a bug
WvV>> where the command line length wasn't checked when it copied the
WvV>> string from the configuration file, it used to work with the 3.2.9b
WvV>> version. But no longer in the 3.4.2, so I got an error when the
WvV>> arccopy command was executed by makenl in my configuration, because
WvV>> the command line was cut short...
AL> Yes, andrew clarke has done a bunch of work on preventing overflows,
AL> including at least one that I created a few versions ago. OOPS!
Yes, I noticed these when comparing sources for 3.2.9 and 3.4.2. Great work!
Because it could prevent some possible buffer overflows!
WvV>> 256 is still arbitrary, but should be enough for most systems. ;)
AL> I would hope so!
Well, you never know. ;)
MAX_PATH on windows for instance, is 260 bytes. And that's just for the
command, not for command line options. And just today I noticed a command line
to start java on a linux server that was over 1300 bytes long. But I don't
think we will see that in the makenl config to start an archiver. Although if
someone wants to write the options in --long-format for readability...
Bye, Wilfred.
--- FMail-W32-1.67.0.46-B20140112
* Origin: Amiga Offline BBS Lisse (2:280/464)
|
