https://gitlab.synchro.net/main/sbbs/-/commit/aaa6fa7e9c801734368bb1b4
Modified Files:
src/sbbs3/email.cpp
Log Message:
Call smb_updatethread() from sbbs_t::email() to perform Keyop "magic"
As discover
ed by Keyop and reported via IRC, when replying *to* a local mail box and *not*
using the hard-coded email menu (e.g. when when using msglist.js), the original
message's "Replied" attribute flag was not set. When replying to a netmail addre
ss (at least, Internet or FidoNet, unsure about QWKnetmail), the attribute would
be set.
This discrepancy was because this email() function doesn't use the "mod
ern" smb_addmsg() function (which also calls smb_updatethread()), but add the me
ssage body text the old/manual way and never called smb_updatethread(). smb_upda
tethread() does the thread linkage stuff (which is usually unnoticed in the mail
base) *and* sets the "Replied" attribute of the original message, if it's not a
lready set.
This function should be overhauled to use smb_addmsg(), but this 2-li
ne change at least addresses this issue for now. There's probably other places (
e.g. importing mail replies via QWK/REP packets) where this thread-linkage and "
Replied" attribute flag setting is still not happening.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
|
